Skip to content

UI: add missing label text for label.aclname #12511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DaanHoogland merged 1 commit into from
Jan 26, 2026
Merged

UI: add missing label text for label.aclname #12511

DaanHoogland merged 1 commit into from
Jan 26, 2026

Conversation

@sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Jan 23, 2026

Description

This PR fixes the label for ACL name, which looks like got removed during some merge conflict resolution.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before:
Screenshot 2026-01-22 at 12 02 54 PM

After:
Screenshot 2026-01-23 at 8 17 01 PM

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87 sudo87 changed the title add missing label text for label.aclname UI: add missing label text for label.aclname Jan 23, 2026
@sudo87
Copy link
Collaborator Author

sudo87 commented Jan 23, 2026

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jan 23, 2026

@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.24%. Comparing base (8db7cab) to head (0da41f5).
⚠️ Report is 18 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #12511   +/-   ##
=========================================
  Coverage     16.24%   16.24%           
  Complexity    13393    13393           
=========================================
  Files          5657     5657           
  Lines        499107   499144   +37     
  Branches      60574    60578    +4     
=========================================
+ Hits          81069    81083   +14     
- Misses       409001   409021   +20     
- Partials       9037     9040    +3
Flag Coverage Δ
uitests 4.03% <ø> (-0.01%) ⬇️
unittests 17.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

blueorangutan commented Jan 23, 2026

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12511 (QA-JID-854)

@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Jan 26, 2026
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 26, 2026

verified in qa, before:
Screenshot 2026-01-26 at 11 15 11
after:
Screenshot 2026-01-26 at 11 15 39

@bernardodemarco
Copy link
Member

bernardodemarco commented Jan 26, 2026

@sudo87 @kiranchavala @DaanHoogland there is the #12196 PR that fixes the same label. Which one of them should we keep?

bernardodemarco
bernardodemarco approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaanHoogland DaanHoogland mentioned this pull request Jan 26, 2026
Closed
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 26, 2026

Ah thanks for pointing out, but again, I think 4.20 needs it to, so let’s go for this one.

@DaanHoogland DaanHoogland merged commit 7536516 into apache:4.20 Jan 26, 2026
24 of 25 checks passed
@DaanHoogland DaanHoogland deleted the fixAclLabel branch January 26, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

Assignees

No one assigned

Labels

component:UI status:needs-review

Projects

None yet

Milestone

4.20.3

Development

Successfully merging this pull request may close these issues.

4 participants

@sudo87 @blueorangutan @DaanHoogland @bernardodemarco